GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/15462
[SPARK-17680] [SQL] [TEST] Added test cases for InMemoryRelation
## What changes were proposed in this pull request?
This pull request adds test cases for the following cases:
- keep all data types with null or without null
- access `CachedBatch` disabling whole stage codegen
- access only some columns in `CachedBatch`
This PR is a part of https://github.com/apache/spark/pull/15219. Here are
motivations to add these tests. When https://github.com/apache/spark/pull/15219
is enabled, the first two cases are handled by specialized (generated) code.
The third one is a pitfall.
In general, even for now, it would be helpful to increase test coverage.
## How was this patch tested?
added test suites itself
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kiszk/spark columnartestsuites
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15462.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15462
----
commit b5e98666937410494c3d88596d89e53fbf22f705
Author: Kazuaki Ishizaki <ishiz...@jp.ibm.com>
Date: 2016-10-13T09:22:38Z
added test suites
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
