Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15009#discussion_r83281329
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -1197,12 +1229,22 @@ private object Client extends Logging {
         // Set an env variable indicating we are running in YARN mode.
         // Note that any env variable with the SPARK_ prefix gets propagated 
to all (remote) processes
         System.setProperty("SPARK_YARN_MODE", "true")
    +
    +    val threadEnabled: Boolean = 
env.get("spark.launcher.internal.thread.enabled").
    +      getOrElse("false").toBoolean
    +
         val sparkConf = new SparkConf
    +    if( threadEnabled) {
    +      for ((key, value) <- env if key.startsWith("spark.")) {
    --- End diff --
    
    This could be `conf.setAll`, but that would entail not including `sys.env` 
values in this `env` argument. Which I think should be the case anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to