Github user mallman commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14690#discussion_r83325529
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala 
---
    @@ -225,13 +225,19 @@ case class FileSourceScanExec(
       }
     
       // These metadata values make scan plans uniquely identifiable for 
equality checking.
    -  override val metadata: Map[String, String] = Map(
    -    "Format" -> relation.fileFormat.toString,
    -    "ReadSchema" -> outputSchema.catalogString,
    -    "Batched" -> supportsBatch.toString,
    -    "PartitionFilters" -> partitionFilters.mkString("[", ", ", "]"),
    -    "PushedFilters" -> dataFilters.mkString("[", ", ", "]"),
    -    "InputPaths" -> relation.location.paths.mkString(", "))
    +  override val metadata: Map[String, String] = {
    +    def seqToString(seq: Seq[Any]) = seq.mkString("[", ", ", "]")
    +    val location = relation.location
    +    val locationDesc =
    +      location.getClass.getSimpleName + seqToString(location.rootPaths)
    --- End diff --
    
    This style emulates the way relations are shown in a query plan, e.g.
    
    `Relation[a#1, b#2]`
    
    I'm in favor of keeping this as-is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to