Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15285#discussion_r83287126
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/worker/ui/LogPage.scala ---
    @@ -115,6 +117,17 @@ private[ui] class LogPage(parent: WorkerWebUI) extends 
WebUIPage("logPage") with
         UIUtils.basicSparkPage(content, logType + " log page for " + pageName)
       }
     
    +  private val UNCOMPRESSED_FILE_LENGTH_CACHE_SIZE = 100
    +  // Cache the file size, since it is expensive to compute the 
uncompressed file size.
    +  private val uncompressedFileLengthCache = CacheBuilder.newBuilder()
    --- End diff --
    
    nit: uncompressedFileLength sounds like it is only for uncompressed files. 
how about fileUncompressedSizeCache?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to