Github user gatorsmile commented on a diff in the pull request:
    --- Diff: 
    @@ -90,6 +105,28 @@ class RegexpExpressionsSuite extends SparkFunSuite with 
ExpressionEvalHelper {
         checkEvaluation("a\nb" like regEx, true, create_row("a%b"))
         checkEvaluation(Literal.create(null, StringType) like regEx, null, 
    +    checkEvaluation("" like regEx, true, create_row(""))
    +    checkEvaluation("a" like regEx, false, create_row(""))
    +    checkEvaluation("" like regEx, false, create_row("a"))
    +    checkEvaluation("""\\\\""" like regEx, true, create_row("""%\\%"""))
    +    checkEvaluation("""%%""" like regEx, true, create_row("""%%"""))
    +    checkEvaluation("""\__""" like regEx, true, create_row("""\\\__"""))
    +    checkEvaluation("""\\\__""" like regEx, false, 
    +    checkEvaluation("""_\\\%""" like regEx, false, create_row("""%\\"""))
    +    checkEvaluation("a\u20ACa" like regEx, true, create_row("_\u20AC_"))
    +    checkEvaluation("a€a" like regEx, true, create_row("_€_"))
    +    checkEvaluation("a€a" like regEx, true, create_row("_\u20AC_"))
    +    checkEvaluation("a\u20ACa" like regEx, true, create_row("_€_"))
    +    checkEvaluation("""a\""" like regEx, false, create_row("""a\"""))  // 
TODO: should throw an exception?
    --- End diff --
    more than 100 characters.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to