Github user nblintao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14158#discussion_r83355296
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
 ---
    @@ -146,11 +158,35 @@ private[ui] abstract class ExecutionTable(
         <div>{desc} {details}</div>
       }
     
    +  private def sqlTextCell(sqlText: String): Seq[Node] = {
    +    // Only show a limited number of characters of sqlText by default when 
it is too long
    +    val maxLength = 140
    --- End diff --
    
    Thanks, @felixcheung. When I am looking at the discussions again today, I 
find I am more clear about your suggestions. But actually, truncating very long 
queries is not because they are not visually pleasant to be displayed on the 
page, but it may take too many resources to store and transfer such a long 
unlimited string. So the queries longer than 1000 chars are truncated after 
parsing, which will never be recovered. So the idea of clipboard may not be 
used to resolve it.
    
    But still, I believe the clipboard is a good idea. I do think we could 
extend the limit to 10k chars instead of 1k if we add a clipboard later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to