Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14690#discussion_r83356659
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -626,6 +627,40 @@ private[spark] class HiveExternalCatalog(conf: 
SparkConf, hadoopConf: Configurat
         client.getPartition(db, table, spec)
       }
     
    +  override def listPartitionsByFilter(
    --- End diff --
    
    Well, `filtering the partition values again` seems a hive specific logic, 
as hive metastore may not support partition pruning and still return all 
partitions. LGTM then


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to