Github user uncleGen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2131#discussion_r16762096
  
    --- Diff: core/src/test/scala/org/apache/spark/CacheManagerSuite.scala ---
    @@ -87,4 +99,12 @@ class CacheManagerSuite extends FunSuite with 
BeforeAndAfter with EasyMockSugar
           assert(value.toList === List(1, 2, 3, 4))
         }
       }
    +
    +  test("verity task metrics updated correctly") {
    +    blockManager = sc.env.blockManager
    +    cacheManager = new CacheManager(blockManager)
    +    val context = new TaskContext(0, 0, 0)
    +    cacheManager.getOrCompute(rdd3, split, context, 
StorageLevel.MEMORY_ONLY)
    +    assert(context.taskMetrics.updatedBlocks.getOrElse(Seq()).size == 2)
    --- End diff --
    
    sorry for my poor coding, I will review again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to