Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16763705
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -121,20 +129,16 @@ private[spark] class DiskStore(blockManager:
BlockManager, diskManager: DiskBloc
}
override def remove(blockId: BlockId): Boolean = {
- val fileSegment = diskManager.getBlockLocation(blockId)
- val file = fileSegment.file
- if (file.exists() && file.length() == fileSegment.length) {
+ val file = diskManager.getFile(blockId.name)
--- End diff --
Yep, for consolidation. But think again for sortShuffleManager, since all
data currently is stored in reduiceId 0 file, then it will lead to some
problem. I am wondering to change the physical filename mapping there too to
solve this problem. since we won't want disk manager to know anything about
shuffle block name mapping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
