Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15484#discussion_r83426422
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -335,13 +366,16 @@ class Analyzer(
     
             Aggregate(groupingAttrs, aggregations, expand)
     
    -      case f @ Filter(cond, child) if hasGroupingFunction(cond) =>
    +      // We should make sure all expressions in condition have been 
resolved.
    --- End diff --
    
    expression in condition could be unresolved, we should check this and 
respect the operator until `Filter.condition` is resolved. A testcase in 
`ResolveGroupingAnalyticsSuite` would fail before this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to