Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15394#discussion_r83428359
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala 
---
    @@ -201,11 +476,13 @@ class WeightedLeastSquaresSuite extends SparkFunSuite 
with MLlibTestSparkContext
         for (fitIntercept <- Seq(false, true);
              regParam <- Seq(0.0, 0.1, 1.0);
              standardizeFeatures <- Seq(false, true)) {
    -      val wls = new WeightedLeastSquares(
    -        fitIntercept, regParam, standardizeFeatures, standardizeLabel = 
true)
    -        .fit(instances)
    -      val actual = Vectors.dense(wls.intercept, wls.coefficients(0), 
wls.coefficients(1))
    -      assert(actual ~== expected(idx) absTol 1e-4)
    +      for (solver <- WeightedLeastSquares.supportedSolvers) {
    +        val wls = new WeightedLeastSquares(fitIntercept, regParam, 
elasticNetParam = 0.0,
    +          standardizeFeatures, standardizeLabel = true, solverType = 
solver)
    +          .fit(instances)
    +        val actual = Vectors.dense(wls.intercept, wls.coefficients(0), 
wls.coefficients(1))
    +        assert(actual ~== expected(idx) absTol 1e-4)
    +      }
           idx += 1
         }
       }
    --- End diff --
    
    Yeah, may be we can leave TODO here to consider remove this arguments for 
WLS. Let's address it in follow up work when we are confidence.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to