Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15459#discussion_r83476207
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreRelationSuite.scala 
---
    @@ -36,4 +38,16 @@ class MetastoreRelationSuite extends SparkFunSuite {
         // No exception should be thrown
         relation.toJSON
       }
    +
    +  test("SPARK-17409: Do Not Optimize Query in CTAS More Than Once") {
    +    withTable("bar") {
    +      withTempView("foo") {
    +        sql("select 0 as id").createOrReplaceTempView("foo")
    +        sql("CREATE TABLE bar AS SELECT * FROM foo group by id")
    --- End diff --
    
    Also put the comment of 
https://github.com/apache/spark/pull/15459/files#diff-5d2ebf4e9ca5a990136b276859769289R1626
 at here? Also mention that this test is for hive format table?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to