Github user ericl commented on the issue:

    https://github.com/apache/spark/pull/14690
  
    > My main concern is that, the new FileCatalog class hierarchy is really 
complex now. Can we simplify it a little? or at least let's put a class 
hierarchy chart(or text explanation) in PR description to make other reviewers 
easier to understand this new hierarchy.
    
    One low-hanging fruit here is to unify SessionFileCatalog with 
PartitionAwareFileCatalog. It seems that after some of the changes here no 
longer need them to be separate. This is a PR I can add on after the rebase is 
finished.
    
    I also think we should rename some of the classes, but since this would be 
an invasive change we can handle it in a follow-up.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to