Github user srowen commented on a diff in the pull request:
    --- Diff: 
core/src/main/java/org/apache/spark/io/ ---
    @@ -0,0 +1,142 @@
    + * Licensed under the Apache License, Version 2.0 (the "License");
    + * you may not use this file except in compliance with the License.
    + * You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +import javax.annotation.concurrent.ThreadSafe;
    +import java.nio.ByteBuffer;
    +import java.nio.channels.FileChannel;
    +import java.nio.file.StandardOpenOption;
    + * {@link InputStream} implementation which uses direct buffer
    + * to read a file to avoid extra copy of data between Java and
    + * native memory which happens when using {@link}.
    + * Unfortunately, this is not something already available in JDK,
    + * {@link} supports reading a file using nio,
    + * but does not support buffering.
    + *
    + * TODO: support {@link #mark(int)}/{@link #reset()}
    + *
    + */
    --- End diff --
    I only see one location in the codebase where we use this annotation, and I 
think we probably shouldn't use it at all if not used consistently. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to