Github user viirya commented on a diff in the pull request:
    --- Diff: 
    @@ -587,6 +594,30 @@ class SQLQuerySuite extends QueryTest with 
SQLTestUtils with TestHiveSingleton {
    +  test("CTAS with default fileformat") {
    +    val table = "ctas1"
    +    val ctas = s"CREATE TABLE IF NOT EXISTS $table SELECT key k, value 
FROM src"
    +    withSQLConf(SQLConf.CONVERT_CTAS.key -> "true") {
    +      withSQLConf("hive.default.fileformat" -> "textfile") {
    +        withTable(table) {
    +          sql(ctas)
    +          // We should use parquet here as that is the default datasource 
fileformat. The default
    +          // datasource file format is controlled by 
`spark.sql.sources.default` configuration.
    +          // This testcase verifies that setting `hive.default.fileformat` 
has no impact on
    +          // the target table's fileformat in case of CTAS.
    +          assert(sessionState.conf.defaultDataSourceName === "parquet")
    +          checkRelation(tableName = table, isDataSourceTable = true, 
format = "parquet")
    --- End diff --
    yeah, I think it is no problem you have all named arguments for them.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to