Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15487#discussion_r83565121
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
 ---
    @@ -29,15 +29,18 @@ import org.apache.spark.sql.types._
      * a single partition, and we use a single reducer to do the aggregation.).
      */
     @ExpressionDescription(
    -  usage = "_FUNC_(expr,isIgnoreNull) - Returns the last value of `child` 
for a group of rows.")
    +  usage = """_FUNC_(expr,isIgnoreNull) - Returns the last value of `child` 
for a group of rows.
    +    _FUNC_(expr,isIgnoreNull=false) - Returns the last value of `child` 
for a group of rows.
    --- End diff --
    
    Ah, I thought it should be as below if it dose not affect anything but only 
this:
    
    ```sql
    spark-sql> DESCRIBE FUNCTION last;
    Function: last
    Class: org.apache.spark.sql.catalyst.expressions.aggregate.Last
    Usage: last(expr,isIgnoreNull) - Returns the last value of `child` for a 
group of rows.
           last(expr,isIgnoreNull=false) - Returns the last value of `child` 
for a group of rows.
             If isIgnoreNull is true, returns only non-null values.
    ```
    
    This was just my personal opinion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to