Github user lw-lin commented on a diff in the pull request:
    --- Diff: 
    @@ -118,7 +118,45 @@ object GenerateOrdering extends 
CodeGenerator[Seq[SortOrder], Ordering[InternalR
    -    comparisons
    +    /*
    --- End diff --
    Thanks @kiszk for bringing this up! @ueshin @kiszk any comments please on 
do we want to expand `CodeGenerator#private splitExpressions` to:
     - add one more argument to specific how we want to "return" things?
     - add arguments to specific in which manner do we want to break 
expression? E.g. in the pr's case, we might want to break it according to the 
`numberOfComparisonsThreshold = 40` rather than on the string length

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to