Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15382#discussion_r83897527
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -741,7 +741,7 @@ private[sql] class SQLConf extends Serializable with
CatalystConf with Logging {
def variableSubstituteDepth: Int = getConf(VARIABLE_SUBSTITUTE_DEPTH)
- def warehousePath: String = new Path(getConf(WAREHOUSE_PATH)).toString
+ def warehousePath: String =
Utils.resolveURI(getConf(WAREHOUSE_PATH)).toString
--- End diff --
> interpreted as an HDFS path by default because that's not how it worked
historically
Except that is how it's worked historically for this piece of code at
least. Taking a small detour, the reason I really dislike the use of
`resolveURI` everywhere (and I commented on this when that code was added) is
that it makes it awkward to use HDFS. Instead of relying on `fs.defaultFS` now
you have to know the HDFS scheme (which can be "hdfs", "maprfs", "s3",
"webhdfs", "viewfs", or others depending on your particular configuration) or
things will break in mysterious ways.
Anyway, I don't really care that much for this particular setting, so if
you think changing the behavior is better, it's fine with me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
