Github user jkbradley commented on a diff in the pull request:
    --- Diff: 
    @@ -83,10 +83,20 @@ class QuantileDiscretizerSuite
    -    // Reserve extra one bucket for NaN
    -    val expectedNumBuckets = - 1
    -    val result =
    -    val observedNumBuckets ="result").distinct.count
    +    // Reserve extra one bucket for NaN values
    +    discretizer.setHandleInvalid("keep")
    +    var expectedNumBuckets = - 1
    --- End diff --
    I'd also recommend directly testing the values of the splits.  The current 
test makes sure that handleInvalid is passed to the bucketizer correctly, which 
is important but separate.
    Also, please use vals (not vars) for clarity.  I'd recommend making a 
helper method for lines 87-93, which can be reused for the test of 
handleInvalid = "skip"

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to