Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/15481#discussion_r83946120
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -392,9 +392,23 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
// Remove all the lingering executors that should be removed but not
yet. The reason might be
// because (1) disconnected event is not yet received; (2) executors
die silently.
- executorDataMap.toMap.foreach { case (eid, _) =>
- driverEndpoint.askWithRetry[Boolean](
- RemoveExecutor(eid, SlaveLost("Stale executor after cluster
manager re-registered.")))
+ // Note: here copy the code of remove executor from DriverEndpoint to
avoid deadlock(reset
+ // and removeExecutor both to get the lock of schedulerbackend.)
+ val reason = SlaveLost("Stale executor after cluster manager
re-registered.")
+ executorDataMap.toMap.foreach { case (executorId, executorInfo) =>
--- End diff --
`executorDataMap` should not be modified outside DriverEndpoint. See the
comment for `executorDataMap`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
