Github user mallman commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -1486,10 +1485,10 @@ private[spark] object Utils extends Logging {
           val gzInputStream = new GZIPInputStream(new FileInputStream(file))
           val bufSize = 1024
    --- End diff --
    Sorry, I know this is beside the point of this PR, but since we have this 
diff here I want to point out that this buffer seems really, really small for 
decompressing and reading a large gzip input stream (by large I mean one with 
an uncompressed file size > 4GB). For smaller files, we can much more 
efficiently get the file size by reading from the gzip file footer, as 
described here:
    What do you think?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to