Github user lw-lin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15480#discussion_r83990016
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
 ---
    @@ -118,7 +118,45 @@ object GenerateOrdering extends 
CodeGenerator[Seq[SortOrder], Ordering[InternalR
               }
           """
         }.mkString("\n")
    -    comparisons
    +
    +    /*
    --- End diff --
    
    @davies could you take a quick look here:
    
    this PR tries to break a huge generated method into smaller pieces. @kiszk 
@ueshin and I were discussing whether we should:
    - (a) just do the breaking-ups case by case, like in this PR
    - or (b) expand `CodeGenerator.splitExpressions(...)` to generally support 
this breaking-ups, like in the POC 
https://github.com/lw-lin/spark/commit/d0c11984e9aa84f68b9ebdd21317f629d759ae86
    
    @davies could you advise on this? thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to