Github user tejasapatil commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskAssigner.scala 
    @@ -0,0 +1,233 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.scheduler
    +import scala.collection.mutable.ArrayBuffer
    +import scala.collection.mutable.PriorityQueue
    +import scala.util.Random
    +import org.apache.spark.internal.{config, Logging}
    +import org.apache.spark.SparkConf
    +import org.apache.spark.util.Utils
    +/** Tracking the current state of the workers with available cores and 
assigned task list. */
    +class OfferState(val workOffer: WorkerOffer) {
    +  // The current remaining cores that can be allocated to tasks.
    +  var coresAvailable: Int = workOffer.cores
    +  // The list of tasks that are assigned to this worker.
    +  val tasks = new ArrayBuffer[TaskDescription](coresAvailable)
    + * TaskAssigner is the base class for all task assigner implementations, 
and can be
    + * extended to implement different task scheduling algorithms.
    + * Together with [[org.apache.spark.scheduler.TaskScheduler 
TaskScheduler]], TaskAssigner
    + * is used to assign tasks to workers with available cores. Internally, 
TaskScheduler, requested
    + * to perform task assignment given available workers, first sorts the 
candidate tasksets,
    + * and then for each taskset, it takes a number of rounds to request 
TaskAssigner for task
    + * assignment with different the locality restrictions until there is 
either no qualified
    + * workers or no valid tasks to be assigned.
    + *
    + * TaskAssigner is responsible to maintain the worker availability state 
and task assignment
    + * information. The contract between 
[[org.apache.spark.scheduler.TaskScheduler TaskScheduler]]
    + * and TaskAssigner is as follows. First, TaskScheduler invokes 
construct() of TaskAssigner to
    --- End diff --
    It might be better to put these into separate points and not as a 
paragraph. Also, I am not sure what the protocol is about putting details like 
method names in the doc. As things stand, it will serve good for people trying 
to read the code but as the codebase evolves, things might get out of sync if 
this comment is not updated.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to