Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15541#discussion_r83998311
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -109,6 +108,85 @@ class TaskSchedulerImplSuite extends SparkFunSuite
with LocalSparkContext with B
assert(!failedTaskSet)
}
+ test("Scheduler does not always schedule tasks on the same workers") {
+ val taskScheduler = setupScheduler()
+ roundrobin(taskScheduler)
+ }
+
+ test("User can specify the roundrobin task assigner") {
+ val taskScheduler = setupScheduler(("spark.scheduler.taskAssigner",
"RoUndrObin"))
+ roundrobin(taskScheduler)
+ }
+
+ test("Fallback to roundrobin when the task assigner provided is not
valid") {
+ val taskScheduler = setupScheduler("spark.scheduler.taskAssigner" ->
"invalid")
+ roundrobin(taskScheduler)
+ }
+
+ test("Scheduler balance the assignment to the worker with more free
cores") {
--- End diff --
I think you should structure this so that tests for the same task assigner
are packed together. Right now, one has the look into each test case to figure
out which policy is being tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
