Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15532#discussion_r84007392
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -124,7 +124,13 @@ case class SortArray(base: Expression, ascendingOrder:
Expression)
override def checkInputDataTypes(): TypeCheckResult = base.dataType
match {
case ArrayType(dt, _) if RowOrdering.isOrderable(dt) =>
- TypeCheckResult.TypeCheckSuccess
+ ascendingOrder match {
+ case Literal(_: Boolean, BooleanType) =>
+ TypeCheckResult.TypeCheckSuccess
+ case _ =>
+ TypeCheckResult.TypeCheckFailure(
+ "Sort order in second argument requires a boolean literal.")
--- End diff --
I just checked the error msg for ExpectsInputTypes and it is not consistent
anymore. Anyway I think this is fine. I will go through this and fix them
myself later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
