Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15523#discussion_r84010085
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -87,7 +87,14 @@ case class FilterExec(condition: Expression, child:
SparkPlan)
// Split out all the IsNotNulls from condition.
private val (notNullPreds, otherPreds) =
splitConjunctivePredicates(condition).partition {
- case IsNotNull(a: NullIntolerant) if
a.references.subsetOf(child.outputSet) => true
+ case IsNotNull(a) => isNullIntolerant(a) &&
a.references.subsetOf(child.outputSet)
+ case _ => false
+ }
+
+ // One expression is null intolerant iff it and its children are null
intolerant
+ private def isNullIntolerant(expr: Expression): Boolean = expr match {
+ case e: NullIntolerant =>
+ if (e.isInstanceOf[LeafExpression]) true else
e.children.forall(isNullIntolerant)
--- End diff --
Even `a` passed the check of `isNullIntolerant`, i.e., it has not non
`NullIntolerant` which wraps output attributes. If it doesn't refer to any
output attributes, we don't need it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
