Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84005447
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -281,9 +294,11 @@ class Analyzer(
s"${VirtualColumn.hiveGroupingIdName} is deprecated; use
grouping_id() instead")
case Aggregate(Seq(c @ Cube(groupByExprs)), aggregateExpressions,
child) =>
- GroupingSets(bitmasks(c), groupByExprs, child,
aggregateExpressions)
+ GroupingSets(
--- End diff --
A more generic comment here would be to put the common code used by Cube,
Rollup & Grouping Sets in a single method. It seems a bit wasteful to rewrite
this into a GroupingSets plan, to pick that up later down the line (especially
since determining things like nullabilty is trivial for Cube and Rollup).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
