Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15538#discussion_r84134470
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -718,7 +717,8 @@ object ParquetFileFormat extends Logging {
}
/**
- * ParquetFileFormat.prepareWrite calls this function to initialize
`redirectParquetLogsViaSLF4J`.
+ * The ParquetFileFormat constructor calls this function to initialize
+ * `redirectParquetLogsViaSLF4J`.
*/
- def redirectParquetLogs(): Unit = {}
+ private def redirectParquetLogs(): Unit = {}
--- End diff --
Yes, because it's not a method. I'm wondering what this method does, and I
think it exists only to cause the `object` to initialize. That's awkward, but
it already exists I guess. Is there really no way to implement a static init
block in Scala? hm. If so then I support this change. It's actually being moved
to a spot where it will be called earlier, and, be called fewer times, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
