Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15556#discussion_r84235630
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -557,7 +561,8 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
*/
private def replay(
eventLog: FileStatus,
- bus: ReplayListenerBus): Option[FsApplicationAttemptInfo] = {
+ bus: ReplayListenerBus,
+ eventsFilter: (String) => Boolean = (s: String) => true):
Option[FsApplicationAttemptInfo] = {
--- End diff --
No, I mean it looked like the method would never need to use any filter
except for the start/end event one. So it doesn't need it as a parameter. That
is, why is it up to the caller? the method filters in what it needs to produce
the info it needs. I could be missing something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
