Github user ankurdave commented on the pull request:
https://github.com/apache/spark/pull/2168#issuecomment-53662064
@rnowling Thanks for this change! I merged #720 hastily, so it's good to
fix any problems it introduced. A few comments:
1. SynthBenchmark is most useful if it's deterministic, so what do you
think about making `seed` default to 0 instead of -1, or changing
SynthBenchmark to set the seed to 0? That way the generated graph should by
default be identical to what it was before, aside from the log-normal formula
change.
2. It would be good to document the parameters to logNormalGraph briefly.
3. Eventually we should probably switch from Scala optional parameters to
the binary-compatible (but much more verbose) builder pattern as in MLlib. For
now I think optional parameters are fine, though.
@jegonzal Could you take a look at the formula change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
