Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15377#discussion_r84573004
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2432,6 +2432,30 @@ private[spark] object Utils extends Logging {
       }
     }
     
    +private[util] object CallerContext extends Logging {
    +  private val callerContextClassExists = {
    +    try {
    +      // scalastyle:off classforname
    +      Class.forName("org.apache.hadoop.ipc.CallerContext")
    +      Class.forName("org.apache.hadoop.ipc.CallerContext$Builder")
    +      // scalastyle:on classforname
    +      true
    +    } catch {
    +      case _: ClassNotFoundException =>
    +        false
    +      case NonFatal(e) =>
    +        logWarning("Fail to load the CallerContext class", e)
    +        false
    +    }
    +  }
    +
    +  private val conf = SparkHadoopUtil.get.conf
    --- End diff --
    
    This doesn't need to be a separate member; it can be a local val.
    Still, why have more than one member here? Initializing 
`callerContextSupported` in one block of code is sufficient and simpler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to