Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15591#discussion_r84578800
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -615,11 +616,8 @@ class CodegenContext {
         val blocks = new ArrayBuffer[String]()
         val blockBuilder = new StringBuilder()
         for (code <- expressions) {
    -      // We can't know how many bytecode will be generated, so use the 
length of source code
    -      // as metric. A method should not go beyond 8K, otherwise it will 
not be JITted, should
    -      // also not be too small, or it will have many function calls (for 
wide table), see the
    -      // results in BenchmarkWideTable.
    -      if (blockBuilder.length > 1024) {
    +      // We can't know how many byte code will be generated, so use number 
of bytes as limit
    +      if (blockBuilder.length > 60 * 1000) {
    --- End diff --
    
    BTW, I just wonder if it is a related change with the problem specified 
JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to