Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/15575
  
    LGTM, since the scope of this PR is just refactoring. 
    
    Let me first post the existing code for `outputPartitioning` in 
`ExpandExec`:
    ```Scala
      // The GroupExpressions can output data with arbitrary partitioning, so 
set it
      // as UNKNOWN partitioning
      override def outputPartitioning: Partitioning = UnknownPartitioning(0)
    ```
    
    It makes sense to set it either `UnknownPartitioning` or 
`child.outputPartitioning`. However, the above code is setting to a wrong 
number of partitions. We need to correct it no matter whether we are using the 
number or not. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to