Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15513
https://github.com/apache/spark/pull/15513#issuecomment-255632253 I
initially wanted to propose that idea but I didn't becuase I was worried of
ignoring existing name rules in each expression.
So, I only replaced obviously arbitrary names to `expr` here and followed
the majority names in each file.
I guess it is a safe choice to mention them in the arguments. Also, I would
like to avoid a lot of potential arguments about naming, for a simple example,
https://github.com/apache/spark/pull/15513#discussion_r84406275
BTW, I guess I didn't use the name `expr` for literal in this PR though.
Will try to double check this one as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
