Github user mengxr commented on the pull request:

    https://github.com/apache/spark/pull/2137#issuecomment-53684027
  
    The assumption is usually unrealistic. For logistic regression, it is 
common to have the predictions be something like 0.99999 or 0.000001, and they 
cannot be interpreted as probabilities without calibration. Logistic regression 
is not responsible for it. I created a JIRA for isotonic regression, which can 
be used for calibration: https://issues.apache.org/jira/browse/SPARK-3278
    
    For the method names, my suggestion would be: add `classify` that outputs 
classes using a threshold, keep `predict` that output the raw predictions. Do 
not distinguish `predictScore` and `predictProb`.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to