Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15596#discussion_r84705344
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -661,6 +661,15 @@ case class HashAggregateExec(
""".stripMargin
}
+ ctx.addNewFunction("releaseResource", s"""
--- End diff --
We do need to release memory by calling these functions. Because we stop
iterating the data early by letting `shouldStop` return true, we won't call
next `processNext` and memory leak will happen. So we wrap these calls in
override `releaseResource` function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
