Github user ajbozarth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15410#discussion_r84742769
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
    @@ -46,6 +63,8 @@ private[history] class HistoryPage(parent: HistoryServer) 
extends WebUIPage("")
                     <script>setAppLimit({parent.maxApplications})</script>
                 } else if (requestedIncomplete) {
                   <h4>No incomplete applications found!</h4>
    +            } else if (eventLogsUnderProcessCount > 0) {
    +              <h4>No completed applications found!</h4>
    --- End diff --
    
    You may want to rebase your code and see if this is still the cleanest way 
of doing this. The code below this was recently changed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to