Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15266#discussion_r84745981
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -252,6 +251,8 @@ case class PreprocessTableInsertion(conf: SQLConf)
extends Rule[LogicalPlan] {
if (expected.dataType.sameType(actual.dataType) && expected.name
== actual.name) {
actual
} else {
+ // Renaming is needed for handling the INSERT statement like
+ // INSERT INTO TABLE tab1 SELECT 1, 2
Alias(Cast(actual, expected.dataType), expected.name)()
--- End diff --
Yes, this is another solution. Let me submit another PR and then we can
decide which one is better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
