Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15556#discussion_r84797936
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -554,10 +559,15 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
/**
* Replays the events in the specified log file and returns information
about the associated
* application. Return `None` if the application ID cannot be located.
+ *
+ * Depending on the eventsFilter, return values may not be populated or
get returned as `None`
+ * because the events carrying the needed data are filtered out and
therefore not replayed.
*/
private def replay(
eventLog: FileStatus,
- bus: ReplayListenerBus): Option[FsApplicationAttemptInfo] = {
+ bus: ReplayListenerBus,
+ eventsFilter: ReplayEventsFilter = SELECT_ALL_FILTER)
+ : (Option[(FsApplicationAttemptInfo, FsApplicationEnvACLInfo)]) = {
--- End diff --
Given the way the return value is used in the two call sites, you could get
away with returning just `ApplicationEventListener` and move some of the logic
currently in this method to `mergeApplicationListing`, since `getAppUI` doesn't
seem to need it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
