Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12394#discussion_r84852205
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
@@ -228,14 +252,22 @@ class BisectingKMeans @Since("2.0.0") (
case Row(point: Vector) => OldVectors.fromML(point)
}
+ val instr = Instrumentation.create(this, rdd)
+ instr.logParams(featuresCol, predictionCol, k, maxIter, seed,
minDivisibleClusterSize)
+
val bkm = new MLlibBisectingKMeans()
.setK($(k))
.setMaxIterations($(maxIter))
.setMinDivisibleClusterSize($(minDivisibleClusterSize))
.setSeed($(seed))
val parentModel = bkm.run(rdd)
- val model = new BisectingKMeansModel(uid, parentModel)
- copyValues(model.setParent(this))
+ val model = copyValues(new BisectingKMeansModel(uid,
parentModel).setParent(this))
+ val summary = new BisectingKMeansSummary(
+ model.transform(dataset), $(predictionCol), $(featuresCol), $(k))
+ model.setSummary(summary)
--- End diff --
yes, I will del this line ASAP. Thanks for your comment!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
