Github user ahmed-mahran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13866#discussion_r84884088
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/scheduler/JobGenerator.scala
 ---
    @@ -146,6 +146,9 @@ class JobGenerator(jobScheduler: JobScheduler) extends 
Logging {
             Thread.sleep(pollTime)
           }
           logInfo("Waited for jobs to be processed and checkpoints to be 
written")
    +
    +      // do final cleanup in the same thread
    +      clearMetadata(Time(clock.getTimeMillis) + 
graph.getMaxInputStreamRememberDuration)
    --- End diff --
    
    Although not intended in the implementation besides it is not the right way 
to be handled (i.e. depending on the eventloop that would be stopped later), 
I'm not sure whether that would be a valid case, but what if for some reason 
the context is intentionally stopped gracefully to be resumed later from a 
checkpoint.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to