Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13891#discussion_r84950134
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -864,6 +864,9 @@ object MimaExcludes {
           // [SPARK-12221] Add CPU time to metrics
           
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.status.api.v1.TaskMetrics.this"),
           
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.status.api.v1.TaskMetricDistributions.this")
    +    ) ++ Seq(
    +      // SPARK-6685
    +      
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.recommendation.ALS.train")
    --- End diff --
    
    I see. It's a developer API, so more reasonable to change, though it's 
still ideal to not change these APIs unless necessary. Try putting the new 
param at the end? I don't think that changes the situation but makes it at 
least source-compatible with any current invocations.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to