Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15574#discussion_r84989523
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GBTRegressor.scala ---
@@ -123,9 +123,17 @@ class GBTRegressor @Since("1.4.0") (@Since("1.4.0")
override val uid: String)
val oldDataset: RDD[LabeledPoint] = extractLabeledPoints(dataset)
val numFeatures = oldDataset.first().features.size
val boostingStrategy =
super.getOldBoostingStrategy(categoricalFeatures, OldAlgo.Regression)
+
+ val instr = Instrumentation.create(this, oldDataset)
+ instr.logParams(params: _*)
+ instr.logNumFeatures(numFeatures)
+ instr.logNumClasses(0)
--- End diff --
Fair enough. I don't think we've promised anyone that these schema are
stable APIs (and we have no way to test it right now). But that'd be good to
do in the future
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
