Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85041254
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/LongOffset.scala
---
@@ -22,8 +22,18 @@ package org.apache.spark.sql.execution.streaming
*/
case class LongOffset(offset: Long) extends Offset {
+ override val json = offset.toString
+
def +(increment: Long): LongOffset = new LongOffset(offset + increment)
def -(decrement: Long): LongOffset = new LongOffset(offset - decrement)
override def toString: String = s"#$offset"
}
+
+object LongOffset {
+
+ def apply(serialized: Offset) : LongOffset = new
LongOffset(serialized.json.toLong)
+
+}
--- End diff --
Not a strict guideline i guess, its matter of the taste of the reviewer
quite a bit. For me i guess where there is no need to visually introduce a gap,
there is no need for an empty line. For example: between `def apply` and `}`
there no need to introduce a separation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
