Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15538#discussion_r85142206
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -718,7 +722,9 @@ object ParquetFileFormat extends Logging {
}
/**
- * ParquetFileFormat.prepareWrite calls this function to initialize
`redirectParquetLogsViaSLF4J`.
+ * The `ParquetFileFormat` constructor calls this method to ensure that
Parquet library log
+ * output is redirected through the SLF4J JUL bridge handler. This
method is a no-op because we
+ * only require that `redirectParquetLogsViaSLF4J` is initialized. This
accomplishes that task.
*/
- def redirectParquetLogs(): Unit = {}
+ private def ensureParquetLogRedirection(): Unit = {}
--- End diff --
I appreciate your diligent feedback, and I agree there are a few different
ways to implement this. However, I truly believe what I've got here is at least
as good as the other options. Unless you object, I'd like to keep the approach
I've taken here as-is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
