Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15621#discussion_r85161018
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -137,65 +133,82 @@ private[ml] class WeightedLeastSquares(
}
}
- // scale aBar to standardized space in-place
- val aBarValues = aBar.values
- var j = 0
- while (j < numFeatures) {
- if (aStd(j) == 0.0) {
- aBarValues(j) = 0.0
- } else {
- aBarValues(j) /= aStd(j)
- }
- j += 1
- }
+ val bBar = summary.bBar / bStd
+ val bbBar = summary.bbBar / (bStd * bStd)
- // scale abBar to standardized space in-place
- val abBarValues = abBar.values
+ val aStd = summary.aStd
val aStdValues = aStd.values
- j = 0
- while (j < numFeatures) {
- if (aStdValues(j) == 0.0) {
- abBarValues(j) = 0.0
- } else {
- abBarValues(j) /= (aStdValues(j) * bStd)
+
+ val aBar = {
+ val _aBar = summary.aBar
+ val _aBarValues = _aBar.values
+ var i = 0
+ // scale aBar to standardized space in-place
+ while (i < numFeatures) {
+ if (aStdValues(i) == 0.0) {
+ _aBarValues(i) = 0.0
+ } else {
+ _aBarValues(i) /= aStdValues(i)
+ }
+ i += 1
}
- j += 1
+ _aBar
}
+ val aBarValues = aBar.values
--- End diff --
You don't have to change the `solve` signature to intermix arrays and
vectors since we just pass `aa` and `ab`. Still, this was just a suggestion to
avoid a few lines of code, so let's just leave it as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
