GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/2186
[SPARK-3266] [Java] Change JavaRDDLike trait to abstract class.
JavaRDDLike's current design is a holdover from an earlier prototype that
tried
to achieve code-reuse for methods like map(), filter(), etc. using the same
builder-trait pattern that the Scala collections library uses. This
approach
didn't work due to some compiler issues, but unfortunately we never removed
the confusing trait implementation.
This patch changes JavaRDDLike from a trait to an abstract base class.
This should be source-compatible with earlier versions.
This change resolves some problems with certain inherited methods having the
wrong signatures in the bytecode (such as max(); see SPARK-3266).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark SPARK-3266
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2186
----
commit 492694bd03e93683b2cf79f7b9d64e33d395a586
Author: Josh Rosen <[email protected]>
Date: 2014-08-28T21:52:46Z
[SPARK-3266] [Java] Change JavaRDDLike trait to abstract class.
JavaRDDLike's current design is a holdover from an earlier prototype that
tried
to achieve code-reuse for methods like map(), filter(), etc. using the same
builder-trait pattern that the Scala collections library uses. This
approach
didn't work due to some compiler issues, but unfortunately we never removed
the confusing trait implementation.
This patch changes JavaRDDLike from a trait to an abstract base class.
This should be source-compatible with earlier versions.
This change resolves some problems with certain inherited methods having the
wrong signatures in the bytecode (such as max(); see SPARK-3266).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
