Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15363#discussion_r85573008
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -373,6 +373,11 @@ object SQLConf {
         .booleanConf
         .createWithDefault(true)
     
    +  val STARJOIN_OPTIMIZATION = 
SQLConfigBuilder("spark.sql.starJoinOptimization")
    +    .doc("When true, it enables join reordering based on star schema 
detection. ")
    +    .booleanConf
    +    .createWithDefault(false)
    --- End diff --
    
    I means make this config internal, and true by default, if we got enough 
confidence.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to