Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85608065
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceOffset.scala
---
@@ -51,4 +54,11 @@ private[kafka010] object KafkaSourceOffset {
def apply(offsetTuples: (String, Int, Long)*): KafkaSourceOffset = {
KafkaSourceOffset(offsetTuples.map { case(t, p, o) => (new
TopicPartition(t, p), o) }.toMap)
}
+
+ /**
+ * Returns [[KafkaSourceOffset]] from a JSON [[SerializedOffset]]
+ */
+ def apply(serialized: SerializedOffset): KafkaSourceOffset = {
--- End diff --
This does not seem to used any where. I think the code in
KafkaSourceOffset.getPartitionOffsets needs to change because it does not take
into account that the param offset can be a SerializedOffset.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
