Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15676#discussion_r85627218
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
    @@ -585,7 +586,19 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
             getAllPartitionsMethod.invoke(hive, 
table).asInstanceOf[JSet[Partition]]
           } else {
             logDebug(s"Hive metastore filter is '$filter'.")
    -        getPartitionsByFilterMethod.invoke(hive, table, 
filter).asInstanceOf[JArrayList[Partition]]
    +        try {
    +          getPartitionsByFilterMethod.invoke(hive, table, filter)
    +            .asInstanceOf[JArrayList[Partition]]
    +        } catch {
    +          case e: InvocationTargetException =>
    +            // SPARK-18167 retry to investigate the flaky test. This 
should be reverted before
    +            // the release is cut.
    +            val retry = Try(getPartitionsByFilterMethod.invoke(hive, 
table, filter))
    +            val full = Try(getAllPartitionsMethod.invoke(hive, table))
    +            logError("getPartitionsByFilter failed, retry success = " + 
retry.isSuccess)
    +            logError("getPartitionsByFilter failed, full fetch success = " 
+ full.isSuccess)
    --- End diff --
    
    I am wondering if we should also log all of partition specs?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to